fix(exec): reject empty command before executor setup#467
Open
not-matthias wants to merge 2 commits into
Open
Conversation
Greptile SummaryAdds early validation for empty exec commands.
Confidence Score: 5/5The PR appears safe to merge. No blocking failures remain. Important Files Changed
Reviews (3): Last reviewed commit: "fix(exec): reject whitespace-only execut..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Merging this PR will not alter performance
|
`codspeed exec` with no command, and `codspeed run` with an empty or
whitespace-only `exec` target, built a BenchmarkTarget with an empty
command that only failed deep inside exec-harness ("Empty command in
stdin input"), surfaced as the cryptic "failed to execute memory
tracker process: exit status: 1" after a full memtrack probe attach.
Enforce a non-empty command at each origin: mark the exec positional
clap-required, and bail in build_benchmark_targets when a config exec
command parses to zero words.
not-matthias
force-pushed
the
cod-3225-exec-empty-command-fail-fast
branch
from
July 23, 2026 16:50
80723f5 to
c4f262e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codspeed execwith no command — andcodspeed runwith an empty or whitespace-onlyexecconfig target — built aBenchmarkTarget::Execwith an empty command. That empty target survived the full orchestrator (memtrack install, eBPF/libc uprobe attach, exec-harness spawn) before exec-harness rejected it withEmpty command in stdin input, surfaced at the top level as the crypticfailed to execute memory tracker process: exit status: 1after a ~2.3s probe detach.The command is only ever supplied at two origins, so each is now validated up front — before any setup work:
codspeed exec): the positionalcommandis now clap-required, so a missing command fails immediately at arg-parse with a usage message.codspeed run):build_benchmark_targetsbails when a configexeccommand parses to zero words, naming the offending target.Fixes COD-3225